Conversation
epq
reviewed
Aug 31, 2019
|
|
||
|
|
||
|
|
||
| console.log('second method'); |
Collaborator
There was a problem hiding this comment.
The second method to increment counter by 2 should be:
counter++;
counter++;
counter = 2 assigns the value of 2 to counter, but doesn't increase the value by 2.
epq
reviewed
Aug 31, 2019
| //4 | ||
|
|
||
| let a ="sky" | ||
| console.log("value of string wil be:rainbow"); |
Collaborator
There was a problem hiding this comment.
the value of the string a will be rainbow? but line 19 has let a = "sky".
Author
|
Thank you so much Elizabeth.
…On Sat, Aug 31, 2019 at 11:21 AM Elizabeth Chan ***@***.***> wrote:
***@***.**** commented on this pull request.
👍
------------------------------
In script.js
<#6 (comment)>
:
> +//2
+console.log('I\'m awesome');
+
+//3
+
+let age;
+console.log("i was happy when i was 14");
+console.log("14");
+age=14;
+console.log("i was happy when i was 14");
+console.log("14");
+
+//4
+
+let a ="sky"
+console.log("value of string wil be:rainbow");
the value of the string a will be rainbow? but line 19 has let a = "sky".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6?email_source=notifications&email_token=AMSH25WNP5Z7ZLLJLGDK7B3QHKEANA5CNFSM4IPJQYDKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDJ3K2Q#pullrequestreview-282309994>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMSH25XRAR3MP2DZLOMMCGLQHKEANANCNFSM4IPJQYDA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
good job 👍